Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: error pages #154

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: error pages #154

wants to merge 4 commits into from

Conversation

EwoutV
Copy link
Collaborator

@EwoutV EwoutV commented Oct 13, 2024 •
edited
Loading

Introduces some long needed error pages, such as a 404 and 405 error page.
Also some CSS cleanup and added some comments in the code where necessary.

closes #129

@EwoutV EwoutV added the enhancement New feature or request label Oct 13, 2024
@EwoutV EwoutV requested a review from smessie October 13, 2024 15:36
@EwoutV EwoutV self-assigned this Oct 13, 2024
smessie
smessie approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@smessie smessie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try out, but went over the code changes and everything seemed fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smessie smessie smessie approved these changes

Assignees

@EwoutV EwoutV

Labels
enhancement New feature or request
Projects
Studieplekken
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add 404 and 405 pages
2 participants
@EwoutV @smessie